Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(rspack): use cow-utils instead #7908

Merged
merged 1 commit into from
Sep 18, 2024
Merged

perf(rspack): use cow-utils instead #7908

merged 1 commit into from
Sep 18, 2024

Conversation

shulaoda
Copy link
Collaborator

Summary

Related to oxc-project/oxc#5586

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Sep 15, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 15, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit dc424eb
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66e71a0c78a68600083653e0

@shulaoda
Copy link
Collaborator Author

!bench

1 similar comment
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Sep 18, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 18, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-09-18 6f17ffa) Current Change
10000_development-mode + exec 2.21 s ± 26 ms 2.23 s ± 45 ms +0.68 %
10000_development-mode_hmr + exec 688 ms ± 16 ms 699 ms ± 34 ms +1.59 %
10000_production-mode + exec 2.83 s ± 40 ms 2.81 s ± 18 ms -0.63 %
arco-pro_development-mode + exec 1.82 s ± 69 ms 1.83 s ± 79 ms +0.42 %
arco-pro_development-mode_hmr + exec 433 ms ± 0.93 ms 433 ms ± 2.8 ms +0.04 %
arco-pro_production-mode + exec 3.25 s ± 66 ms 3.28 s ± 67 ms +0.92 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.31 s ± 93 ms 3.29 s ± 60 ms -0.57 %
threejs_development-mode_10x + exec 1.67 s ± 24 ms 1.67 s ± 18 ms -0.28 %
threejs_development-mode_10x_hmr + exec 781 ms ± 8.3 ms 790 ms ± 7.4 ms +1.16 %
threejs_production-mode_10x + exec 5.15 s ± 20 ms 5.16 s ± 28 ms +0.20 %

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Sep 18, 2024

Thanks!

@h-a-n-a h-a-n-a merged commit d34d398 into web-infra-dev:main Sep 18, 2024
33 checks passed
@shulaoda shulaoda deleted the perf/cow-utils branch September 18, 2024 12:59
JSerFeng pushed a commit that referenced this pull request Sep 29, 2024
@shulaoda @JSerFeng
perf: use cow-utils instead (#7908)
3cdfb15 
perf(rspack): use cow-utils instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees
No one assigned
Labels
release: performance release: performance related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shulaoda @h-a-n-a @rspack-bot